<html>
<head><meta charset="utf-8"><title>changing in-tree · t-cargo · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/index.html">t-cargo</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/changing.20in-tree.html">changing in-tree</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="217664722"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/changing%20in-tree/near/217664722" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/changing.20in-tree.html#217664722">(Nov 23 2020 at 18:26)</a>:</h4>
<p>I need to make an in-tree (in rust-lang/rust) cargo change for <a href="https://github.com/rust-lang/rust/issues/79336">#79336</a>, but I can't figure out how to stage changes in the submodule :/</p>
<p>I tried <code>git add src/tools/cargo</code>, but nothing happens. How do I do this?</p>



<a name="217664848"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/changing%20in-tree/near/217664848" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/changing.20in-tree.html#217664848">(Nov 23 2020 at 18:27)</a>:</h4>
<p>You have to check out <code>rust-lang/cargo</code> and make a PR to the cargo repository.</p>



<a name="217665055"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/changing%20in-tree/near/217665055" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/changing.20in-tree.html#217665055">(Nov 23 2020 at 18:29)</a>:</h4>
<p>Hmm, but I'm renaming a feature used in a cargo test: don't they need to land at the same time?</p>



<a name="217665756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/changing%20in-tree/near/217665756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/changing.20in-tree.html#217665756">(Nov 23 2020 at 18:35)</a>:</h4>
<p>This is the particular test:</p>
<div class="codehilite"><pre><span></span><code>src/tools/cargo/tests/testsuite/custom_target.rs
65:        // Requires features no_core, lang_items, auto_traits
87:                #![feature(auto_traits)]
</code></pre></div>



<a name="217665768"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/changing%20in-tree/near/217665768" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/changing.20in-tree.html#217665768">(Nov 23 2020 at 18:35)</a>:</h4>
<p>(That's <em>with</em> the change)</p>



<a name="217676947"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/changing%20in-tree/near/217676947" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/changing.20in-tree.html#217676947">(Nov 23 2020 at 20:09)</a>:</h4>
<p><span class="user-mention" data-user-id="307537">@Camelid</span> Those tests are not run on rust-lang/rust, so it is OK to break them.  As a courtesy, you can post a PR to rust-lang/cargo after your PR lands on nightly, or I can do it when I get a chance.</p>



<a name="217676990"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/changing%20in-tree/near/217676990" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/changing.20in-tree.html#217676990">(Nov 23 2020 at 20:09)</a>:</h4>
<p>All the <code>is_nightly</code> tests are disabled on rust-lang/rust for this reason.</p>



<a name="217677013"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/changing%20in-tree/near/217677013" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/changing.20in-tree.html#217677013">(Nov 23 2020 at 20:09)</a>:</h4>
<p>Great, good to know</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>